Coordinate grid xDomain change #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay change. Need to trigger an update to xScale
|
This logic is getting really hairy. I wonder if there would be any risk to just always rescaling. Are there cases where we actually want the |
|
The only reason not to may be performance, but I believe that has fairly minimal overhead anyway. |
|
Moved that hairy logic to a function, and compare elements by string value for good measure (to avoid date problems). Thanks @mtraynham! |
|
Thanks Gordon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossfilter always provides every row, even if the measure value is 0. When not using Crossfilter, this will almost never be the case.
This check ensures that the xAxis is updated if the previous domain length is not equal to that of the new domain.